Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENGG-1682] feat: rules executions support; extension icon green, executed rules in popup #1671

Merged
merged 6 commits into from May 13, 2024

Conversation

wrongsahil
Copy link
Member

Closes issue:

πŸ“œ Summary of changes:

βœ… Checklist:

  • Make sure linting and unit tests pass.
  • No install/build warnings introduced.
  • Verified UI in browser.
  • For UI changes, added/updated analytics events (if applicable).
  • For changes in extension's code, manually tested in Chrome and Firefox.
  • For changes in extension's code, both MV2 and MV3 are covered.
  • Added/updated unit tests for this change.
  • Raised pull request to update corresponding documentation (if already exists).

πŸ§ͺ Test instructions:

πŸ”— Other references:

Copy link

deepsource-io bot commented May 7, 2024

Here's the code health analysis summary for commits d1ddf13..bca0325. View details on DeepSourceΒ β†—.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShellβœ…Β SuccessView CheckΒ β†—
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 53 occurences introduced
🎯 24 occurences resolved
View CheckΒ β†—

πŸ’‘ If you’re a repository administrator, you can configure the quality gates from the settings.

case RuleType.CANCEL:
case RuleType.DELAY:
rule.pairs.forEach((pair) => {
if (matchSourceUrl(pair.source, details.url)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only URL is being matched. We would also need to match source filters: resourceType, requestMethod and pageDomain/initiator domain

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DNR rules have excludedInitiatorDomains

"excludedInitiatorDomains": [
                    "requestly.io"
                ]

So, we should also not check rule matches for requestly initiator domains

@wrongsahil wrongsahil force-pushed the extension-icon-green-on-rule-execution branch from 8757157 to 8cc6028 Compare May 12, 2024 21:29
@nafees87n nafees87n merged commit 15da788 into master May 13, 2024
2 of 3 checks passed
@nafees87n nafees87n deleted the extension-icon-green-on-rule-execution branch May 13, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants