Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENGG-1567 ENGG-1568] MV3: auto migration of rules #1669

Closed
wants to merge 36 commits into from
Closed

Conversation

nafees87n
Copy link
Contributor

Closes issue:

πŸ“œ Summary of changes:

βœ… Checklist:

  • Make sure linting and unit tests pass.
  • No install/build warnings introduced.
  • Verified UI in browser.
  • For UI changes, added/updated analytics events (if applicable).
  • For changes in extension's code, manually tested in Chrome and Firefox.
  • For changes in extension's code, both MV2 and MV3 are covered.
  • Added/updated unit tests for this change.
  • Raised pull request to update corresponding documentation (if already exists).

πŸ§ͺ Test instructions:

πŸ”— Other references:

Copy link

deepsource-io bot commented May 7, 2024

Here's the code health analysis summary for commits d2caa42..5f646f2. View details on DeepSourceΒ β†—.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShellβœ…Β SuccessView CheckΒ β†—
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 42 occurences introduced
🎯 37 occurences resolved
View CheckΒ β†—

πŸ’‘ If you’re a repository administrator, you can configure the quality gates from the settings.

@nafees87n nafees87n changed the title [ENGG-1567] MV3: auto migration of rules [ENGG-1567 ENGG-1568] MV3: auto migration of rules May 7, 2024
@wrongsahil wrongsahil self-requested a review May 8, 2024 11:51
@nafees87n nafees87n requested a review from wrongsahil May 9, 2024 10:57
@nafees87n
Copy link
Contributor Author

Closing this as changed pulled in #1688

@nafees87n nafees87n closed this May 15, 2024
@nafees87n nafees87n deleted the ENGG-1567 branch May 15, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants