Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENGG-1646] feat: collection support for mocks #1634

Merged
merged 102 commits into from May 13, 2024
Merged

[ENGG-1646] feat: collection support for mocks #1634

merged 102 commits into from May 13, 2024

Conversation

rohanmathur91
Copy link
Member

Closes issue:

📜 Summary of changes:

✅ Checklist:

  • Make sure linting and unit tests pass.
  • No install/build warnings introduced.
  • Verified UI in browser.
  • For UI changes, added/updated analytics events (if applicable).
  • For changes in extension's code, manually tested in Chrome and Firefox.
  • For changes in extension's code, both MV2 and MV3 are covered.
  • Added/updated unit tests for this change.
  • Raised pull request to update corresponding documentation (if already exists).

🧪 Test instructions:

🔗 Other references:

@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Apr 25, 2024 •
edited

Here's the code health analysis summary for commits 7ff78a0..4754466. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 105 occurences introduced
🎯 146 occurences resolved
View Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@rohanmathur91 rohanmathur91 mentioned this pull request Apr 30, 2024
Closed
wrongsahil
wrongsahil requested changes Apr 30, 2024
View reviewed changes
app/src/features/mocks/modals/CreateCollectionModal/index.tsx Outdated Show resolved Hide resolved
app/src/features/mocks/modals/CreateCollectionModal/index.tsx Outdated Show resolved Hide resolved
app/src/features/mocks/screens/mocksList/components/MocksList/MocksList.tsx Outdated Show resolved Hide resolved
app/src/backend/mocks/createCollection.ts Outdated Show resolved Hide resolved
app/src/backend/mocks/updateCollections.ts Outdated Show resolved Hide resolved
...c/features/mocks/screens/mocksList/components/MocksList/components/MocksTable/MocksTable.tsx Outdated Show resolved Hide resolved
...c/features/mocks/screens/mocksList/components/MocksList/components/MocksTable/utils/index.ts Outdated Show resolved Hide resolved
app/src/backend/mocks/updateMocksCollectionId.ts Outdated Show resolved Hide resolved
app/src/features/mocks/modals/DeleteCollectionModal/index.tsx Outdated Show resolved Hide resolved
app/src/componentsV2/ContentList/components/ContentListTable/ContentListTable.tsx Outdated Show resolved Hide resolved
@rohanmathur91 rohanmathur91 mentioned this pull request May 10, 2024
Merged
8 tasks
@rohanmathur91 rohanmathur91 merged commit d1ddf13 into master May 13, 2024
2 of 3 checks passed
@rohanmathur91 rohanmathur91 deleted the ENGG-1646 branch May 13, 2024 04:12
@rohanmathur91
Copy link
Member Author

Closes #1652

@rohanmathur91 rohanmathur91 mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrongsahil wrongsahil wrongsahil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rohanmathur91 @wrongsahil