Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RQ-650 Dropdown bug fixed #1330

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DhruvBachani
Copy link

@DhruvBachani DhruvBachani commented Jan 5, 2024

Click area of dropdowns in filter modal of Rules is text only. Made it to be the whole dropdown item as mentioned in the issue.

Closes issue: #1132

πŸ“œ Summary of changes:

Moved the onclick property to the Menu Item instead of span to allow clicking on the item itself in the dropdown rather than only text.

βœ… Checklist:

  • Make sure linting and unit tests pass.
  • No install/build warnings introduced.
  • Verified UI in browser.
  • For UI changes, added/updated analytics events (if applicable).
  • For changes in extension's code, manually tested in Chrome and Firefox.
  • For changes in extension's code, both MV2 and MV3 are covered.
  • Added/updated unit tests for this change.
  • Raised pull request to update corresponding documentation (if already exists).

πŸ§ͺ Test instructions:

  • Create a new HTTP rule
  • Select filters
  • Select any option from the dropdown next to Page URL

πŸ”— Other references:

N/A

Click area of dropdowns in filter modal of Rules is text only. Made it to be the whole dropdown item as mentioned in the issue.
@DhruvBachani DhruvBachani marked this pull request as draft January 5, 2024 12:30
@DhruvBachani DhruvBachani marked this pull request as ready for review January 5, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant