Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1208 [RQ-1145] Relay auth header to redirected request #1253

Merged
merged 6 commits into from
Dec 8, 2023
Merged

#1208 [RQ-1145] Relay auth header to redirected request #1253

merged 6 commits into from
Dec 8, 2023

Conversation

lazyvab
Copy link
Contributor

@lazyvab lazyvab commented Dec 4, 2023

Closes issue: #1208

📜 Summary of changes:

✅ Checklist:

  • Make sure linting and unit tests pass.
  • No install/build warnings introduced.
  • Verified UI in browser.
  • For UI changes, added/updated analytics events (if applicable).
  • For changes in extension's code, manually tested in Chrome and Firefox.
  • For changes in extension's code, both MV2 and MV3 are covered.
  • Added/updated unit tests for this change.
  • Raised pull request to update corresponding documentation (if already exists).

🧪 Test instructions:

🔗 Other references:

@nafees87n nafees87n changed the title #1208 Relay auth header to redirected request #1208 [RQ-1145] Relay auth header to redirected request Dec 6, 2023
nafees87n
nafees87n approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@nafees87n nafees87n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nafees87n nafees87n merged commit 3516bb5 into master Dec 8, 2023
1 check passed
wrongsahil added a commit that referenced this pull request Dec 12, 2023
@wrongsahil
Revert "#1208 [RQ-1145] Relay auth header to redirected request (#1253)"
671d0b7 
This reverts commit 3516bb5.
@wrongsahil wrongsahil mentioned this pull request Dec 12, 2023
Merged
wrongsahil added a commit that referenced this pull request Dec 12, 2023
@wrongsahil
Revert "#1208 [RQ-1145] Relay auth header to redirected request (#1253)…
9ddf25d 
…" (#1271)

This reverts commit 3516bb5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nafees87n nafees87n nafees87n approved these changes

@sachinjain024 sachinjain024 Awaiting requested review from sachinjain024

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lazyvab @nafees87n