feat: Add Elasticsearch 8.x support #6904
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NGPixel
reviewed
Dec 27, 2023
|
What is missing for this to land in main? |
Code wise should be complete now. I've tested with ES 7.x, and 8.x and all features seem to be working as expected. I don't have a 6.x cluster setup, so I wasn't able to test. @NGPixel, I modified the code to keep the type field for 6.x and 7.x, and merged in upstream changes. Can you review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify ElasticSearch search module to support v8.x.
Changes:
6.x is EOL and no longer supported by ElasticSearch; Some of the logic can be further simplified if support for 6.x is dropped.
Tests:
I've tested fairly extensively with 8.x creating, deleting and renaming pages to validate indices are created. I have not done any regression testing against 6.x or 7.x ElasticSearch.