Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove calendar and matomo packages as well as daily statistics #986

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ovbm
Copy link
Contributor

@ovbm ovbm commented Dec 30, 2024

No description provided.

@ovbm ovbm requested review from lucianak and hdahlheim December 30, 2024 14:09
Copy link
Contributor

@lucianak lucianak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but some things are still missing:

  • migrations need to be handled somehow, at the moment this would fail. Maybe we could introduce a new migration that deletes the calendar tables in a different module, and the js files in the migration module need to be deleted
    will not break anything, but for cleanup:
  • remove calendar stuff from extractPersonalData script
  • remove translations

@ovbm
Copy link
Contributor Author

ovbm commented Jan 6, 2025

Looks good, but some things are still missing:

  • migrations need to be handled somehow, at the moment this would fail. Maybe we could introduce a new migration that deletes the calendar tables in a different module, and the js files in the migration module need to be deleted
    will not break anything, but for cleanup:
  • remove calendar stuff from extractPersonalData script
  • remove translations

Good point. What if we add a sqls folder in the backend-modules "migrations" and:

  1. copy and paste all the migration sqls files from the modules we want to delete into that folder
  2. change the reference in the migration's javascript files

Or alternatively: We delete all related migration files. If we're getting rid of the table anyways, we might as well delete those.

Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
staging-republik-love ✅ Ready (Inspect) Visit Preview Jan 6, 2025 4:04pm

@ovbm
Copy link
Contributor Author

ovbm commented Jan 6, 2025

  • Removed translation strings
  • Removed reference in extractPersonalData
  • Removed all migration.js files referencing calendar migrations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants