Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable viewing video attachments #3999

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

LyubomirStoimchev
Copy link

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?

Visuals

report-portal-video-viewer.mov

@LyubomirStoimchev
Copy link
Author

Most of the solution is copied and modified from the Image viewer modal. This solution uses the HTML5 video implementation.

The only thing that I've found so far is that there is not "Video" attachment image. I have no idea how to exactly generate them, that is why I used the HTML image.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.15%. Comparing base (4ceec25) to head (6cc7138).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3999      +/-   ##
===========================================
+ Coverage    60.11%   60.15%   +0.04%     
===========================================
  Files           80       80              
  Lines          875      876       +1     
  Branches       128      128              
===========================================
+ Hits           526      527       +1     
  Misses         321      321              
  Partials        28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AmsterGet
Copy link
Member

Hello @LyubomirStoimchev !
Thank you very much for your suggestion and Pull request!
Having such a feature in the app will be very helpful for our users.
I have discussed your suggestion with the team and we have created a ticket in our backlog. As part of this task, we will review the PR soon and provide feedback.
At least, we need to decide what other types of videos we should be able to play in addition to mp4.

@AmsterGet AmsterGet removed the request for review from Vadim73i September 4, 2024 16:18
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants