Replace connect with hooks in 3 components
#7552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![replay-soc2[bot]](https://avatars.githubusercontent.com/u/60818315?s=60&v=4){kind=small}
Andarist
commented
Aug 15, 2022
| members: "Team Members", | ||
| api: "API Keys", | ||
| }; | ||
| setTab(views[view]); |
There was a problem hiding this comment.
This was trying to derive the local state from the selected state - so I've just refactored this to use the actual selected state right from the start
Andarist
commented
Aug 15, 2022
| @@ -130,7 +129,6 @@ const settings: Settings< | |||
| settings?: any; | |||
| isAdmin: boolean; | |||
| workspaceId: string; | |||
| hideModal: PropsFromRedux["hideModal"]; | |||
There was a problem hiding this comment.
If I read this correctly... only TeamMembers were actually using hideModal so I've just moved it directly to it and cleaned this up from the parent components
|
Thanks! I'll merge this probably early next week |
markerikson
force-pushed
the
deconnectify-few-components
branch
from
ffdbebe to
70a58a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing with reduxjs/react-redux#1940 and I've started looking into the codebase here. Since I've never actually used "modern Redux" in an app I've figured out that it would be a nice exercise to migrate a few components to hooks.
Feel free to do whatever u want with this PR 😉 cc @markerikson