Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasource/custom): better logging for jsonata errors #31520

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

Add debug log for when jsonata rules fail to transform the response from datasource

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs prettier fix else LGTM

@viceice
Copy link
Member

viceice commented Sep 21, 2024

not a refactor, because exceptions are catched and null is returned

@RahulGautamSingh RahulGautamSingh changed the title refactor(datasource/custom): better logging for jsonata errors fix(datasource/custom): better logging for jsonata errors Sep 23, 2024
@rarkins rarkins added this pull request to the merge queue Sep 25, 2024
Merged via the queue into renovatebot:main with commit 1405689 Sep 25, 2024
38 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 38.95.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants