feat(config/validation): add validation for negative numbers

[RahulGautamSingh]

Changes

• Validate negative numbers when they are set for integer types.

Context

Ref this discussion: #29137 (comment)

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[rarkins]

Are you sure we never use a negative number like -1 intentionally?

[RahulGautamSingh]

Are you sure we never use a negative number like -1 intentionally?

We do but only for prPriority. I am still to add that change here, after figuring out how it works. It is a config option which should always have a parent but we do not validate it like one. I think one more PR before this one is needed to validate it like fileMatch.

[rarkins]

I think that this PR is maybe oversimplifying things. Not all numbers need to be positive, even if most are. A broad rule doesn't work.

Also yes, prPriority should always be part of packageRules

[RahulGautamSingh]

We can add allowNegative field for config options of type: integer. That will help differentiate them better.

[rarkins]

Please test against a real repo and show us the results.

[RahulGautamSingh]

Repro: Rahul-renovate-testing/feat-29178#1

[renovate-release]

🎉 This PR is included in version 37.387.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)
• 37.387.0

Your semantic-release bot 📦🚀