feat(pip-compile): Provide credentials for registries in all input files #28959
+149
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pip-compile can compile multiple input files into one lock file. Renovate calls the manager's `updateArtifacts` function once for each input file, but currently it only looks for private package registries in the input file currently being processed. This changes it to look for them in all of the input files.
mbudnek
changed the title
viceice
reviewed
May 17, 2024
viceice
reviewed
May 27, 2024
| @@ -47,11 +47,9 @@ export function cleanRegistryUrls(registryUrls: string[]): string[] { | |||
| }); | |||
| } | |||
|
|
|||
| export function extractPackageFile( | |||
| export function extractPackageFileFlags( | |||
There was a problem hiding this comment.
i would prefer to move this to a common.ts and directly import, so it's not a member of the public manager api.
Maybe we should do this as a refactor before this PR.
mbudnek
added a commit
to mbudnek/renovate
that referenced
this pull request
May 30, 2024
Move the matchManager function to common.ts since it will be used in artifacts.ts in renovatebot#28959
6 tasks
mbudnek
added a commit
to mbudnek/renovate
that referenced
this pull request
May 30, 2024
The pip-compile manager will need to extract flags from pip requirements files in renovatebot#28959, so move that code into a common.ts
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Pip-compile can compile multiple input files into one lock file. Renovate calls the manager's
updateArtifactsfunction once for each input file, but currently it only looks for private package registries in the input file currently being processed. This changes it to look for them in all of the input files.Context
#28958
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: