Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency tar to v7 #28786

Closed
wants to merge 1 commit into from
Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 2, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
tar 6.2.1 -> 7.1.0 age adoption passing confidence

Release Notes

isaacs/node-tar (tar)

v7.1.0

Compare Source

v7.0.1

Compare Source

v7.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

viceice
viceice previously approved these changes May 2, 2024
@viceice viceice enabled auto-merge May 2, 2024 10:46
@viceice viceice disabled auto-merge May 6, 2024 08:48
@viceice viceice marked this pull request as draft May 6, 2024 08:48
@renovate renovate bot force-pushed the renovate/tar-7.x branch 14 times, most recently from 1b842aa to 7e8750f Compare May 6, 2024 18:25
@rarkins
Copy link
Collaborator

rarkins commented May 6, 2024

Error: node_modules/.pnpm/[email protected]/node_modules/tar/dist/commonjs/pack.d.ts(70,5): error TS2416: Property 'end' in type 'Pack' is not assignable to the same property in base type 'Minipass<Buffer, ContiguousData>'.
  Type '(path?: string | ReadEntry | undefined) => this' is not assignable to type '{ (cb?: (() => void) | undefined): this; (chunk: any, cb?: (() => void) | undefined): this; (chunk: any, encoding?: Encoding | undefined, cb?: (() => void) | undefined): this; }'.
    Types of parameters 'path' and 'cb' are incompatible.
      Type '(() => void) | undefined' is not assignable to type 'string | ReadEntry | undefined'.
        Type '() => void' is not assignable to type 'string | ReadEntry | undefined'.
Error: node_modules/.pnpm/[email protected]/node_modules/tar/dist/commonjs/pack.d.ts(71,5): error TS2[41](https://github.com/renovatebot/renovate/actions/runs/8973329797/job/24643254585?pr=28786#step:4:42)6: Property 'write' in type 'Pack' is not assignable to the same property in base type 'Minipass<Buffer, ContiguousData>'.
  Type '(path: string | ReadEntry) => boolean' is not assignable to type '{ (chunk: ContiguousData, cb?: (() => void) | undefined): boolean; (chunk: ContiguousData, encoding?: Encoding | undefined, cb?: (() => void) | undefined): boolean; }'.
    Types of parameters 'path' and 'chunk' are incompatible.
      Type 'ContiguousData' is not assignable to type 'string | ReadEntry'.
        Type 'ArrayBuffer' is not assignable to type 'string | ReadEntry'.

@rarkins rarkins closed this May 6, 2024
@rarkins rarkins deleted the renovate/tar-7.x branch May 6, 2024 18:28
Copy link
Contributor Author

renovate bot commented May 6, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 7.x releases. But if you manually upgrade to 7.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@viceice viceice restored the renovate/tar-7.x branch May 7, 2024 06:13
@viceice viceice reopened this May 7, 2024
@viceice
Copy link
Member

viceice commented May 7, 2024

we need to wait a day or so, then renovate will suggest v7.1, which is working again

@renovate renovate bot force-pushed the renovate/tar-7.x branch 19 times, most recently from 98d2c21 to 2e2aa3c Compare May 13, 2024 11:25
@rarkins rarkins marked this pull request as ready for review May 13, 2024 11:36
@rarkins
Copy link
Collaborator

rarkins commented May 13, 2024

@viceice v7.1.0 is out but still with this error:

Error: node_modules/.pnpm/[email protected]/node_modules/tar/dist/commonjs/pack.d.ts(70,5): error TS2416: Property 'end' in type 'Pack' is not assignable to the same property in base type 'Minipass<ContiguousData, Buffer, WarnEvent>'.
  Type '(path?: string | ReadEntry | undefined) => this' is not assignable to type '{ (cb?: (() => void) | undefined): this; (chunk: Buffer, cb?: (() => void) | undefined): this; (chunk: Buffer, encoding?: Encoding | undefined, cb?: (() => void) | undefined): this; }'.
    Types of parameters 'path' and 'cb' are incompatible.
      Type '(() => void) | undefined' is not assignable to type 'string | ReadEntry | undefined'.
        Type '() => void' is not assignable to type 'string | ReadEntry | undefined'.
Error: node_modules/.pnpm/[email protected]/node_modules/tar/dist/commonjs/pack.d.ts(71,5): error TS2[41](https://github.com/renovatebot/renovate/actions/runs/9062206423/job/24895580512?pr=28786#step:4:42)6: Property 'write' in type 'Pack' is not assignable to the same property in base type 'Minipass<ContiguousData, Buffer, WarnEvent>'.
  Type '(path: string | ReadEntry) => boolean' is not assignable to type '{ (chunk: Buffer, cb?: (() => void) | undefined): boolean; (chunk: Buffer, encoding?: Encoding | undefined, cb?: (() => void) | undefined): boolean; }'.
    Types of parameters 'path' and 'chunk' are incompatible.
      Type 'Buffer' is not assignable to type 'string | ReadEntry'.
        Type 'Buffer' is missing the following properties from type 'ReadEntry': #private, header, startBlockSize, blockRemain, and 75 more.
 ELIFECYCLE  Command failed with exit code 2.
ERROR: "tsc --noEmit" exited with 2.
 ELIFECYCLE  Command failed with exit code 1.

| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | tar     | 6.2.1 | 7.1.0 |
@viceice
Copy link
Member

viceice commented May 13, 2024

yes, anoying 😕

@viceice viceice closed this May 13, 2024
@viceice
Copy link
Member

viceice commented May 13, 2024

i think it now needs node v20+ types

@renovate renovate bot deleted the renovate/tar-7.x branch May 13, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants