Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use standard debian packages #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmikedupont2
Copy link

removing the embedded lib and compiling using standard debian packages. The one problem that I found was the the test had the lib before the file.

@raucao
Copy link
Member

raucao commented Oct 23, 2016

Thanks for the PR!

I'm afraid there's currently nobody maintaining this program, and it would also need upgrading to a newer version of the remoteStorage protocol. If you're interested in fixing and perhaps even improving rs-serve, I could give you commit access and you could basically change whatever code you want (except for removing/changing the license and original author credits, of course).

Regarding the PR itself, and without knowing much about C programming, just one question: the "debian" in the title makes it sound like this might not work on other distributions? I can't see anything debian-specific though, so I guess what this is doing is requiring the dependencies to be pre-installed from whatever distro's package manager, right?

@jmikedupont2
Copy link
Author

I dont think i am ready to take on that yet

On Oct 23, 2016 4:06 PM, "Sebastian Kippe" [email protected] wrote:

Thanks for the PR!

I'm afraid there's currently nobody maintaining this program, and it would
also need upgrading to a newer version of the remoteStorage protocol. If
you're interested in fixing and perhaps even improving rs-serve, I could
give you commit access and you could basically change whatever code you
want (except for removing/changing the license and original author credits,
of course).

Regarding the changes themselves, and without knowing much about C
programming, just one question: the "debian" in the title makes it sound
like this might not work on other distributions? I can't see anything
debian-specific though, so I guess what this is doing is requiring the
dependencies to be pre-installed from whatever distro's package manager,
right?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#13 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/APqoaUBDvDeRU5UIAxp6OPwnAwtbuM_Vks5q22n-gaJpZM4KeHnu
.

@raucao
Copy link
Member

raucao commented Oct 25, 2016

No problem!

Care to answer my question about the code changes though? It seems like you got it building on your machine, so that would be a good improvement to merge, of course.

@jmikedupont2
Copy link
Author

Yes. I need to revisit it. is possible to test or use it as it is. Maybe I
don't need the new stuff

On Oct 25, 2016 3:52 PM, "Sebastian Kippe" [email protected] wrote:

No problem!

Care to answer my question about the code changes though? It seems like
you got it building on your machine, so that would be a good improvement to
merge, of course.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#13 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/APqoadTFpUcEHF0Q_gwQZr53LjDgemo1ks5q3l38gaJpZM4KeHnu
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants