Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full profile search #763

Merged
merged 23 commits into from
May 6, 2020
Merged

Add full profile search #763

merged 23 commits into from
May 6, 2020

Conversation

nylen
Copy link
Collaborator

@nylen nylen commented May 4, 2020

This pull request modifies the "filter" box on the list homepage to search through all company profile data.

You can read more about how the search works here: https://blog.remoteintech.company/search-help/ This page is also linked from the "More info" text at the search box.

Screenshot

Try it first!

You can try this before it's merged by going here: https://deploy-preview-763--remote-jobs.netlify.app/ Please let me know if you see any issues.

@auto-nylen
Copy link

Hi @nylen, thanks for your contribution!

Our automated checks detected some problems with this pull request (as of commit b1f1975). See below for details:


Please fix these issues and push a new commit to this pull request.

@nylen
Copy link
Collaborator Author

nylen commented May 4, 2020

@dougaitken I guess I need to fix the bot before this is merged, otherwise it will probably keep causing problems later on. Please do try out the search though, it's ready to play with at https://deploy-preview-763--remote-jobs.netlify.app/

I also see "Loading search data... Infinity%" when this is hosted on Netlify. I'll fix that in this PR too.

nylen added 2 commits May 4, 2020 22:39
This probably doesn't matter right now due to the way the scripts are
currently structured, but it might matter one day and it's more logical
this way.
@auto-nylen

This comment has been minimized.

@auto-nylen

This comment has been minimized.

@auto-nylen

This comment has been minimized.

@auto-nylen

This comment has been minimized.

@auto-nylen

This comment has been minimized.

@auto-nylen

This comment has been minimized.

2 similar comments
@auto-nylen

This comment has been minimized.

@auto-nylen
Copy link

🤖 ⚠️

Sorry, this bot is currently having issues. It's probably @nylen's fault, not yours. We'll look into it.

🤖 ⚠️

nylen added 2 commits May 5, 2020 01:19
When a Node.js error occurs the exit code is probably going to be 1, so
we should use a different code.
@nylen nylen force-pushed the add/full-profile-search branch from 0567cc1 to 9e84e21 Compare May 5, 2020 01:19
@auto-nylen
Copy link

Hi @nylen, thanks for updating the pull request! According to our automated checks, everything looks OK now (as of commit 9e84e21). ✔️

@nylen
Copy link
Collaborator Author

nylen commented May 5, 2020

OK, this is all good from my end.

@nylen nylen requested a review from dougaitken May 5, 2020 02:34
nylen added 2 commits May 5, 2020 03:01
This was wrong (out of date), but the correct version is obvious from
reading the code.
@dougaitken
Copy link
Member

Flipping 'eck.

This is incredible. Are you using offline workers or something for the search?

I can't break it so let's do this.

I think for #464 and #569 we could maybe add things like region: type fitlers like how GitHub and other places use search terms? That said, this is such a huge improvement. Thank you so much.

@dougaitken dougaitken merged commit dac8b04 into master May 6, 2020
@nylen
Copy link
Collaborator Author

nylen commented May 7, 2020

Glad you like it, I had fun building it.

Are you using offline workers or something for the search?

It's using https://lunrjs.com/ which if I remember correctly is the same library that Calypso devdocs uses. The new code here uses Lunr to generate an index of all the data every time the site gets built. The index is just a different way to organize the data so that it can be searched quickly - basically a map of all the words that appear in our data and where they can be found. Then when you start searching on the site, it downloads the latest index data and the actual searching happens in your browser using that index.

we could maybe add things like region: type filters

Good thing to look into for a future enhancement. This already works pretty well though - if you search for "react" then you're going to get all the companies that use React.

@nylen nylen deleted the add/full-profile-search branch May 7, 2020 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand the Search scope to all of the profile rather than name and region Add a filter for "needs more info"
3 participants