Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new company: Renaissance #1691

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Add new company: Renaissance #1691

merged 4 commits into from
Oct 25, 2023

Conversation

dhruvchandak30
Copy link
Contributor

@dhruvchandak30 dhruvchandak30 commented Oct 10, 2023 •
edited by dougaitken
Loading

This is a modified version of, and should adhere to, the Contributing Guidelines.

  • This PR contains housekeeping only (URL edits, copy changes etc) - if this is checked, delete other lines that don't apply
  • You are an employee of the company mentioned and confirm all included details are correct.
  • You know your alphabet - company is listed in alphabetical order in the README.md file.
  • The company directly hires employees. ** No bootcamps / freelance sites / etc**
  • The company hires remote employees, or positions are available to remote workers and are clearly illustrated as such.
  • A company profile is included - This is required for new additions.
  • An entry has been added or edited within the readme.md file.
  • Remote status has details regarding how the culture includes remote employees, how the company integrated remote workers, etc
  • Region details the geographic regions in which this company employees can reside. For more details see the instructions in the example company profile.
  • How to apply details the best approach for new applications, page on site where open position are listed, and any other help available for job hunters

Ki-er
Ki-er requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@Ki-er Ki-er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be made.

company-profiles/renaissance.md Outdated Show resolved Hide resolved
@Ki-er
Copy link
Member

Ki-er commented Oct 10, 2023

Thanks for the speedy changes, let me know when it is ready for review!

@Ki-er Ki-er added addition awating-review Yet to be reviewed labels Oct 10, 2023
@dhruvchandak30
Copy link
Contributor Author

Thanks for the speedy changes, let me know when it is ready for review!

@KieranRobson It is ready for review.

@dhruvchandak30 dhruvchandak30 requested a review from Ki-er October 10, 2023 14:20
Ki-er
Ki-er requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@Ki-er Ki-er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick change to be made!

company-profiles/renaissance.md Outdated

Renaissance’s solutions help educators analyze, customize, and plan personalized learning paths for students, allowing time for what matters—creating energizing learning experiences in the classroom. More than one-third of U.S. schools use Renaissance solutions to accelerate learning for millions of students.

## Company technologies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is for the technologies that the company uses for development etc not for the tech it produces.

Copy link
Contributor Author

@dhruvchandak30 dhruvchandak30 Oct 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is nowhere mention which Technologies they use. Should I remove this section?
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal but keep the header for the section and leave it blank. The company is aimed at technology but it's not even clear on their job listings what technologies they use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
It is giving me an error.

@Ki-er Ki-er added author-reply-needed and removed awating-review Yet to be reviewed labels Oct 10, 2023
dougaitken
dougaitken requested changes Oct 11, 2023
View reviewed changes
Copy link
Member

@dougaitken dougaitken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the region in the readme line removing UK, and delete the content but keep the header for Company technologies @dhruvchandak30

README.md Outdated Show resolved Hide resolved
@dougaitken
Copy link
Member

@dhruvchandak30 Sorry for the delay. If you can, can you remove the Company technologies header? The build is complaining and I forgot a header needs to be removed if it's empty.

@dhruvchandak30
Copy link
Contributor Author

@dhruvchandak30 Sorry for the delay. If you can, can you remove the Company technologies header? The build is complaining and I forgot a header needs to be removed if it's empty.

Sure, I will remove it.

@dhruvchandak30
Copy link
Contributor Author

@dougaitken I have removed the Technologies' Header.

@dougaitken dougaitken merged commit a2a98d4 into remoteintech:main Oct 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ki-er Ki-er Ki-er requested changes

@dougaitken dougaitken dougaitken approved these changes

Assignees
No one assigned
Labels
addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhruvchandak30 @Ki-er @dougaitken