Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand the Search scope to all of the profile rather than name and region #584

Closed
dougaitken opened this issue Jun 28, 2019 · 4 comments · Fixed by #763
Closed

Expand the Search scope to all of the profile rather than name and region #584

dougaitken opened this issue Jun 28, 2019 · 4 comments · Fixed by #763

Comments

@dougaitken
Copy link
Member

Related to #569

Currently, when someone wants to search the list, they are limited to name and region. Having the ability to search the whole profile would allow for filtering by technology or another keyword.

@whatacold
Copy link
Contributor

whatacold commented Jul 10, 2019

Just being curious, where can we search these data from? It takes a lot of time for me to see every company's websites :(.

Edit: Just found out that there are more details about every company in the company-profiles directory, cool!

@dougaitken dougaitken added the hacktoberfest This site was born from Hacktoberfest. meta label Oct 7, 2019
@nylen nylen removed the hacktoberfest This site was born from Hacktoberfest. meta label Nov 1, 2019
@noobyogi0010
Copy link

Hey @dougaitken !
I would like to work on this by adding additional filtering in search. Can you please tell me how to get started with contributing?
Thanks.

@dougaitken
Copy link
Member Author

Hey @noobyogi0010 - @nylen is best to confirm but I'm unsure how this should be done. Currently it is a search/filter happening here - https://github.com/remoteintech/remote-jobs/blob/master/site/assets/companies-table.js

For context, this list is compiled into a static site that lives on Netlify.

@nylen
Copy link
Collaborator

nylen commented Feb 23, 2020

Hi @noobyogi0010, you can see the documentation for how the site is currently built here: https://github.com/remoteintech/remote-jobs/tree/master/site

In order to solve this issue, you'll need to make the data (text) from the rest of the company profile available to the search function on the main page. This is the companies-table.js code that Doug mentioned.

I'm not sure the best way to make this work. It will require some custom code and perhaps changing the library that is used for the search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants