Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically check project summations (AR6, NAVIGATE), bugfixes ar6climate, fixOnRef, policyCosts #1587

Merged
merged 5 commits into from
Mar 12, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Feb 28, 2024

Purpose of this PR

  • automatically run script that converts remind2 data into AR6 and NAVIGATE data and runs a variable summation check and a regional summation check. Prints results to log. The scripts fails in case of problems, but that fail basically does nothing, except output.R telling the user it failed. The regional summation check has to skip several Emissions|* variables because they have bunkers included on the World level, but not in the regions as this was the default for AR6.
  • for fixOnRef, add option cfg$fixOnRefAuto to the config that allows to autocorrect wrong fixing. Not sure whether we want to activate that as usual. I would rather prefer to fix it the EDGE-T issues at the core, but as long as magpie does not know reference fixing, this switch is useful for coupled runs.
  • for fixOnRef, use TRUE_or_fixed to avoid asking if the user wants to update if everything is fine
  • for fixOnRef, set scenario name correctly for MAGICC6 data. Be more clear what was changed and why.
  • add higher memory requirements for nashAnalysis
  • if an output/single script does not exist, skip this script, not the whole outputdir
  • update _withoutPlus file after writing MAGICC7.5.3 data
  • fix bug in policyCosts plotting after I named the data dimension correctly as variable in this remind2 PR but did not adjust this script.

Type of change

  • New feature

Checklist:

  • My code follows the coding etiquette
  • I performed a self-review of my own code
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • Some automated model tests pass: testOneRegi fails because of this error. Everything before is fine, also codeCheck succeeds, and test_06-output.R also works (after I put some fulldata.gdx into the testOneRegi folder).
  • The changelog CHANGELOG.md has been updated correctly

@orichters orichters force-pushed the smallfix4 branch 4 times, most recently from 1ac5c96 to 6d379fd Compare February 29, 2024 15:44
@orichters orichters changed the title automatically check export summations automatically check project summations (AR6, NAVIGATE) Feb 29, 2024
@orichters orichters force-pushed the smallfix4 branch 2 times, most recently from 8a0710b to a0a8253 Compare March 5, 2024 16:10
@orichters orichters changed the title automatically check project summations (AR6, NAVIGATE) automatically check project summations (AR6, NAVIGATE), bugfixes ar6climate + fixOnRef Mar 5, 2024
@orichters orichters force-pushed the smallfix4 branch 3 times, most recently from 8ffabaf to 75e4933 Compare March 5, 2024 17:05
@orichters orichters marked this pull request as ready for review March 5, 2024 17:16
config/default.cfg Outdated Show resolved Hide resolved
@LaviniaBaumstark
Copy link
Member

please also run make test :-)

@orichters
Copy link
Contributor Author

please also run make test :-)

Please provide a calibration where testOneRegi does not fail (🦆 and cover)

@orichters orichters changed the title automatically check project summations (AR6, NAVIGATE), bugfixes ar6climate + fixOnRef automatically check project summations (AR6, NAVIGATE), bugfixes ar6climate, fixOnRef, policyCosts Mar 7, 2024
@orichters orichters merged commit 0a61fc2 into remindmodel:develop Mar 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants