Port keybindings and supports. #1566
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move initially defined keybindings to Rust. Use 'AsRef' Trait to make keybinding definition more hygienic. Along with 'KeyChar' the need for casting is contained within 'initially_defined_key'.
shaleh
commented
Feb 26, 2020
| @@ -5466,9 +5466,15 @@ fi || AC_MSG_ERROR(['src/epaths.h' could not be made.]) | |||
|
|
|||
|
|
|||
| CARGO_DEFAULT_FEATURES="" | |||
There was a problem hiding this comment.
These were added to allow all of the keybindings to be ported.
shaleh
commented
Feb 26, 2020
| @@ -1756,17 +1758,6 @@ pub extern "C" fn reset_buffer_local_variables(mut buffer: LispBufferRef, includ | |||
| buffer.reset_local_variables(include_permanent) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This code was moved to the end to make it easier to find.
shaleh
commented
Feb 26, 2020
| @@ -1982,4 +1973,23 @@ pub fn byte_char_debug_check(b: LispBufferRef, charpos: isize, bytepos: isize) { | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
KeyChar here is saving us from casting between chars, u8, and EmacsInt.
shaleh
commented
Feb 26, 2020
| @@ -262,37 +264,6 @@ pub fn recursive_edit() { | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Solely a move for easier managing.
shaleh
commented
Feb 26, 2020
| @@ -5278,12 +5278,14 @@ Functions running this hook are, `get-buffer-create', | |||
| Fput (intern_c_string ("erase-buffer"), Qdisabled, Qt); | |||
| } | |||
|
|
|||
| #ifdef IGNORE_RUST_PORT | |||
There was a problem hiding this comment.
This is never defined. But it makes merges from emacs easier. No more missing functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move initially defined keybindings to Rust.
Use 'AsRef' Trait to make keybinding definition more hygienic.
Along with 'KeyChar' the need for casting is contained within
'initially_defined_key'.