Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Romanian translation #36

Closed
wants to merge 1 commit into from
Closed

Conversation

ThomDietrich
Copy link

Pull Request Template for Home Assistant / Lovelace Card Repository

Overview

Original pull request by @rumbu13: AitorDB#137

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Documentation update
  • Refactoring
  • Other (please describe):

Checklist

Please ensure that you have completed the following tasks before submitting your pull request:

  • I have read the contributing guidelines for this project.
  • I have tested my changes against the dev branch (or another appropriate branch) and verified that they are working as expected.
  • I have updated the documentation (if applicable) to reflect my changes.
  • My changes adhere to the repository's code style guidelines.
  • My changes do not introduce any breaking changes or unexpected behaviors.

Related Issues / Pull Requests

Please include any related issues or pull requests that this change is associated with, and use the appropriate keywords (Closes, Fixes, Resolves) to automatically close the related issues when this pull request is merged.

  • Closes #issue_number
  • Fixes #issue_number
  • Resolves #issue_number

Additional Details

Please provide any additional information that you feel is relevant to this pull request, such as screenshots, code snippets, or examples.

@ThomDietrich ThomDietrich added the norelease Do not bump the semantic version and release a build to HACS label Mar 27, 2023
@edwardtfn
Copy link
Collaborator

edwardtfn commented Mar 27, 2023

Could you please add the new language to the README.md?

edwardtfn added a commit that referenced this pull request Mar 27, 2023
Complete changes for #36 which is based on original pull request by @rumbu13: AitorDB#137
@edwardtfn edwardtfn mentioned this pull request Mar 27, 2023
11 tasks
@edwardtfn
Copy link
Collaborator

edwardtfn commented Mar 27, 2023

Please use #38 instead as I've added the changes in the other files.

Sorry, I haven't seen this was draft. 🫣

@edwardtfn edwardtfn closed this Mar 27, 2023
@edwardtfn edwardtfn reopened this Mar 27, 2023
@ThomDietrich
Copy link
Author

No worries @edwardtfn :)
Would you like to add your completing changes from #38 as an additional commit and merge? Thanks!

@edwardtfn
Copy link
Collaborator

I cannot do this right now. Please go ahead if you want to do that, otherwise I take a look at this later (or tomorrow).

@ThomDietrich
Copy link
Author

Merged in c1e42e3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
norelease Do not bump the semantic version and release a build to HACS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants