Flip sunrise/sunset & dusk/dawn when southern_flip is true #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, shouldn't Moonrise and Moonset be switched around as well to ensure consistency? |
Yes, Updated =) |
|
Hey @jesserockz, this looks great. Would you like to add anything to the README file? |
|
Hello! This fix would be very helpful. |
|
Hey @jesserockz if you added a quick note the the README, I'd gladly merge your PR |
|
Sorry @ThomDietrich I didnt really know what to add to the readme and forgot to come back to it |
ThomDietrich
added
the
release:minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template for Home Assistant / Lovelace Card Repository
Overview
Using the
southern_flipconfig flag, I swapped the sunset/sunrise, dusk/dawn and moonrise/moonset elements.Type of Change
Checklist
Please ensure that you have completed the following tasks before submitting your pull request:
devbranch (or another appropriate branch) and verified that they are working as expected.Related Issues / Pull Requests
Please include any related issues or pull requests that this change is associated with, and use the appropriate keywords (
Closes,Fixes,Resolves) to automatically close the related issues when this pull request is merged.Additional Details
Please provide any additional information that you feel is relevant to this pull request, such as screenshots, code snippets, or examples.