Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moon phase translation key #134

Merged

Conversation

trvrnrth
Copy link

@trvrnrth trvrnrth commented May 18, 2024

Overview

Fixes the moon phase translation key.

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Documentation update
  • Refactoring
  • Other (please describe):

Checklist

Please ensure that you have completed the following tasks before submitting your pull request:

  • I have tested my changes against the dev branch (or another appropriate branch) and verified that they are working as expected.
  • I have updated the documentation (if applicable) to reflect my changes.
  • My changes adhere to the repository's code style guidelines.
  • My changes do not introduce any breaking changes or unexpected behaviors.

Related Issues / Pull Requests

Fixes #122

@trvrnrth trvrnrth force-pushed the fix-moon-phase-translation-key branch from 2c7487f to 350c982 Compare May 18, 2024 14:34
@ThomDietrich
Copy link

Hey @trvrnrth, thanks for the contribution! Looking good :)
Could you please resolve the checks errors? Thank you!

@trvrnrth trvrnrth force-pushed the fix-moon-phase-translation-key branch from 350c982 to 6ba488e Compare May 21, 2024 08:47
@trvrnrth
Copy link
Author

Hey @trvrnrth, thanks for the contribution! Looking good :) Could you please resolve the checks errors? Thank you!

That's odd. Those test failure snapshot diffs are the NNBSP being missing. I wonder why that's different to my local test run. I've pulled out those snapshot changes and that can be a puzzle for a different day/PR!

@ThomDietrich ThomDietrich merged commit 7687e0d into rejuvenate:main May 21, 2024
2 of 3 checks passed
@trvrnrth trvrnrth deleted the fix-moon-phase-translation-key branch May 21, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moon phase integration not recognized after 2024.4 update
2 participants