-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for authors with no email address in git log #252
base: master
Are you sure you want to change the base?
Conversation
The CI failure looks unrelated, but it's not clear to me what's going on.
|
Anyone? @rjkoch, it looks like you touched this repository most recently. Sorry to pester, but we've currently got a PR on h5py that we can't merge without either fixing this or figuring out some workaround. |
@takluyver No need to apologize, I'm looking into this now, it wasn't on my radar at all until you tagged me. I'd like to get the CI working before merging. Does |
@takluyver Something upstream has broken the test, the last merged commit (which passed when it merged) is no longer passing. will need a couple days to dig into this. Sorry to hold things up. |
No worries. We've actually decided to stop using the 'authors' activity - beyond this specific issue, it has been tricky for new contributors to correctly add themselves to
|
@takluyver I had similar issues with I've looked into it and |
Yup, I was setting |
It's not common, but it does happen. I'm not going to force people to reveal their email address if they don't want to.
Closes #251.