add news item #1221
Merged
add news item #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobleesj
reviewed
Dec 13, 2024
news/cookie-news.rst
Outdated
|
|
||
| **Fixed:** | ||
|
|
||
| * Repo structure modified to the new diffpy standard |
There was a problem hiding this comment.
Maybe need to have "cookiecutter" in the news? since we will be mostly use that term when we revisit?
There was a problem hiding this comment.
"Repo structure modified to the new diffpy (cookiecutter) standard"? And we should update the instruction on here too? https://github.com/Billingegroup/cookiecutter/tree/main
There was a problem hiding this comment.
Yes, if you could make an issue, i will address it
There was a problem hiding this comment.
I created an issue in cookiecutter repo: Billingegroup/cookiecutter#185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1214. I added
cookie-news.rstto thenews/folder per cookiecutting instruction. Let me know if we need anything else here!