Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove python-dateutil in pip.txt and conda.txt #1217

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Remove python-dateutil in pip.txt and conda.txt #1217

merged 7 commits into from
Dec 13, 2024

Conversation

bobleesj
Copy link
Contributor

Closes #1195 - check the package dependencies

@github-actions GitHub Actions
Copy link

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.

@bobleesj bobleesj changed the title Remove wxpython, flatten-dict, python-dateutil in pip.txt and conda.txt Remove flatten-dict, python-dateutil in pip.txt and conda.txt Dec 12, 2024
@bobleesj
Copy link
Contributor Author

(Waiting for the CI to pass)

@bobleesj bobleesj changed the title Remove flatten-dict, python-dateutil in pip.txt and conda.txt Remove python-dateutil in pip.txt and conda.txt Dec 12, 2024
bobleesj
bobleesj commented Dec 12, 2024
View reviewed changes
requirements/build.txt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SInce build.txt is used for gsl, compilers, etc.

@bobleesj
Copy link
Contributor Author

@sbillinge ready for review - codecov is failing for some reason... (this odd behavior is also occurring in diffy.utils https://github.com/diffpy/diffpy.utils/actions/runs/12305919524/job/34346535354?pr=216). Other than that, ready for merge.

Screenshot 2024-12-12 at 5 32 13 PM

@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.64%. Comparing base (569050b) to head (495f97c).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1217   +/-   ##
=======================================
  Coverage   79.64%   79.64%           
=======================================
  Files          17       17           
  Lines        1366     1366           
=======================================
  Hits         1088     1088           
  Misses        278      278

@sbillinge
Copy link
Contributor

Simply ran and it passed. The codecov action is pretty buggy/unstable

@sbillinge sbillinge merged commit 054b004 into regro:main Dec 13, 2024
4 of 5 checks passed
@bobleesj bobleesj deleted the remove-deps branch December 13, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check the package dependencies
2 participants
@bobleesj @sbillinge