Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX - Error: img is a self-closing tag and must neither have children nor use dangerouslySetInnerHTML. #3307

Merged
merged 6 commits into from
May 15, 2024

Conversation

Yummy-Yums
Copy link
Contributor

@Yummy-Yums Yummy-Yums commented May 14, 2024

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

@Yummy-Yums
Copy link
Contributor Author

Yummy-Yums commented May 14, 2024

closes #3273

@Yummy-Yums
Copy link
Contributor Author

Yummy-Yums commented May 14, 2024

@masenf please review

@Yummy-Yums
Copy link
Contributor Author

integration-app-harness passes locally i.e. poetry run pytest integration

image

@ElijahAhianyo ElijahAhianyo force-pushed the Fix--Image-is-Self-Closing-Tag branch from 6819935 to 2546546 Compare May 15, 2024 11:12
@masenf masenf merged commit efa9fcd into reflex-dev:main May 15, 2024
46 checks passed
benedikt-bartscher pushed a commit to benedikt-bartscher/reflex that referenced this pull request May 16, 2024
… nor use dangerouslySetInnerHTML. (reflex-dev#3307)

* fixed errors

* fix CI errors

* CI fix again

* used ruff formatting

* pyi fix

* fix app harness

---------

Co-authored-by: Elijah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants