Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirgrate from pip to uv #3285

Merged
merged 1 commit into from
May 15, 2024
Merged

Mirgrate from pip to uv #3285

merged 1 commit into from
May 15, 2024

Conversation

ericwb
Copy link
Contributor

@ericwb ericwb commented May 13, 2024

In order to improve build time performance, this change switches usage of pip to uv. The uv command is a pip alternative promising much faster installs of Python packages.

For more information on uv, see:
https://github.com/astral-sh/uv

Closes #2748

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

In order to improve build time performance, this change switches
usage of pip to uv. The uv command is a pip alternative promising
much faster installs of Python packages.

For more information on uv, see:
https://github.com/astral-sh/uv

Closes: reflex-dev#2748

Signed-off-by: Eric Brown <[email protected]>
@Lendemor
Copy link
Collaborator

I've compared the execution time to other PRs that don't use uv yet, but I don't find any significant improvement on the runtime of jobs.

However, I think we can still go ahead with this PR anyway.

@ericwb
Copy link
Contributor Author

ericwb commented May 14, 2024

I've compared the execution time to other PRs that don't use uv yet, but I don't find any significant improvement on the runtime of jobs.

However, I think we can still go ahead with this PR anyway.

Yeah, I didn't see much of a performance boost. I suspect its probably because poetry is installing most of the dependencies.

@Lendemor Lendemor merged commit bd3df68 into reflex-dev:main May 15, 2024
46 checks passed
benedikt-bartscher pushed a commit to benedikt-bartscher/reflex that referenced this pull request May 16, 2024
In order to improve build time performance, this change switches
usage of pip to uv. The uv command is a pip alternative promising
much faster installs of Python packages.

For more information on uv, see:
https://github.com/astral-sh/uv

Closes: reflex-dev#2748

Signed-off-by: Eric Brown <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate GitHub Actions to use UV
2 participants