add module prefix to generated state names #3214
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prefixes all state names with their python module to prevent naming conflicts. Defining the same State class name multiple times in different modules is now possible. Consider this example:
myapp/pages/index.py
myapp/pages/about.py
Adjusted all tests except the actual
State.get_name
andState.get_full_name
tests to use dynamic state names. This allows us to implement minified state names later.Added
get_state_name
andget_full_state_name
helpers toAppHarness
for easy testing with parametrized app_names.Validate state cls module names in init_subclass hook. They should not contain
___
as it's used as state name module separator.