Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lru caching #3101

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Lru caching #3101

wants to merge 4 commits into from

Conversation

AmanSal1
Copy link
Contributor

@AmanSal1 AmanSal1 commented Apr 17, 2024

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR. 
Addition of LRU Caching 

b. Describe your changes.
 LRU Caching using third party libraries and adding the associated test case for it .

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).
Fixes: 

#3021

@AmanSal1
Copy link
Contributor Author

@ElijahAhianyo I accidently committed in the same branch . I have changed only state.py and test_state.py .

@Lendemor
Copy link
Collaborator

This PR is removing upload.py when it shouldn't.

We won't be able to merge it until the changes to upload.py are removed from the PR.

@AmanSal1
Copy link
Contributor Author

@Lendemor Just a demo PR, need not be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants