Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clean-conversation-sidebar safer #6667

Merged
merged 5 commits into from
May 24, 2023
Merged

Conversation

@FloEdelmann FloEdelmann added bug disabled via hotfix A label to remind us to remove the feature from yolo labels May 19, 2023
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I don't see how this affects the labels dropdown though, it's not selected by [aria-label="Link issues"] p nor [aria-label="Select reviewers"] > .css-truncate

source/features/clean-conversation-sidebar.tsx Outdated Show resolved Hide resolved
source/helpers/dom-utils.ts Show resolved Hide resolved
@FloEdelmann
Copy link
Member Author

I don't see how this affects the labels dropdown though

Indeed, I didn't have to change anything there, because apparently GitHub changed the HTML again. So the feature basically works without changes (apart from the one in dom-utils.ts).

fregante added a commit to refined-github/yolo that referenced this pull request May 21, 2023
@fregante
Copy link
Member

fregante commented May 21, 2023

You're right, I dropped the hotfix for now. I suppose this PR is not just "Make feature safer" rather than "Restore it"

I think I've been using the feature in the dev version for a long time and didn't even realize. Maybe because it's not as clean as it used to be, the spacing got a little messed up/wider:

Screenshot

@fregante fregante removed the disabled via hotfix A label to remind us to remove the feature from yolo label May 21, 2023
@fregante fregante changed the title Restore clean-conversation-sidebar Make clean-conversation-sidebar safer May 22, 2023
@fregante fregante merged commit 9dff134 into main May 24, 2023
11 checks passed
@fregante fregante deleted the clean-conversation-sidebar branch May 24, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

clean-conversation-sidebar breaks dropdowns
2 participants