Skip to content

Commit

Permalink
gonna have to cut some features for 2.0 prob
Browse files Browse the repository at this point in the history
  • Loading branch information
redruin1 committed Dec 24, 2023
1 parent 4d69f2e commit 90a061c
Show file tree
Hide file tree
Showing 44 changed files with 1,462 additions and 2,462 deletions.
9 changes: 9 additions & 0 deletions TODO.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# TODO

### Calling validate on a blueprint should validate all of it's child entitylikes and tiles (or should it?)

### `OverlappingElementWarning` should only be issued when desired

### If `validate_assignment` on a blueprint is `True`, does that mean that an appended entity or tile should be validated? Should overlapping object warnings be issued?

### Redo validation (again)
Swapping to Pydantic was very illuminating in the benefits that it can provide:

Expand Down Expand Up @@ -81,6 +87,9 @@ Files done:
- [ ] `tools`
- [ ] `*`

---
### Reinvestigate making an entity's `tile_position` based off of it's `position`

---
### Make draftsman's prototypes match Factorio's prototypes exactly (for consistency's sake)
As of writing there are a number of classes and class types that differ due to python functionality; it might make sense to unify the two so that class `AssemblingMachine` inherits the same classes in Factorio as it does in Draftsman.
Expand Down
5 changes: 5 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@
* Added a new command line option for `draftsman-update` `--lua-version`, which prints the version of Lua currently being used for debugging compat issues
* Added a README.md to the `examples` folder which provides short descriptions for all of the examples
* Integrated aforementioned examples into the test suite
* Removed the `area`, `tile_width`, and `tile_height` properties from `Blueprint`, which have been replaced with `get_world_bounding_box()` and `get_dimensions()`
* These attributes are no longer cached in the blueprint and have to be recalculated each time such information is desired
* However, this means that it only has to be calculated when the user actually wants it, instead of every time a user adds a new entity/tile to a blueprint
* The user has a better idea of when they can cache the blueprint's dimension to reduce calculation, so it's deferred to the user
* By making them functions it also makes it abundantly clear that calling them is not likely `O(1)`
* Normalized all import filenames to use underscores consistently (potentially breaking change!)
* Changed the code to be primarily Python3 compatible
* Switched from `unittest` to `pytest` (more features with similar syntax; `coverage run` still works the same)
Expand Down
536 changes: 226 additions & 310 deletions docs/discusssion/2.0.0_release/2.0.0_release.md

Large diffs are not rendered by default.

Loading

0 comments on commit 90a061c

Please sign in to comment.