Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: Fix double call to stop() in http::client #18304

Merged

Commits on May 8, 2024

  1. http: Fix double call to stop() in http::client

    - http::client::stop() can be called twice in the event the client is
    used via the `with_client` method.
    
    - The method had unconditionally called stop() in a finally clause with
    the intention to have users not have to manually do this and forget to
    call stop.
    
    - However stop() can also be called within certain exception handlers
    within methods invoked by http::client, ones that handle
    tls::verification_error exceptions.
    
    - This patch adds a boolean to our http client so that stop() can early
    exit if it has already been called.
    graphcareful committed May 8, 2024
    Configuration menu
    Copy the full SHA
    2ed203d View commit details
    Browse the repository at this point in the history