Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new INFO evicted_scripts field and eval scripts eviction #2686

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Add new INFO evicted_scripts field and eval scripts eviction #2686

merged 4 commits into from
Mar 14, 2024

Conversation

enjoy-binbin
Copy link
Collaborator

@enjoy-binbin enjoy-binbin commented Mar 13, 2024 •
edited
Loading

@netlify Netlify
Copy link

netlify bot commented Mar 13, 2024 •
edited
Loading

👷 Deploy request for redis-doc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f5a5791

oranagra
oranagra reviewed Mar 13, 2024
View reviewed changes
commands/eval.md Outdated Show resolved Hide resolved
@oranagra oranagra added the to-be-merged should probably be merged soon label Mar 13, 2024
@enjoy-binbin @oranagra
Update commands/eval.md
508e87a 
Co-authored-by: Oran Agra <[email protected]>
enjoy-binbin
enjoy-binbin commented Mar 13, 2024
View reviewed changes
commands/eval.md Outdated Show resolved Hide resolved
zuiderkwast
zuiderkwast reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I had written some draft comments but they were very similar to Oran's suggestions which are already resolved.

commands/eval.md Outdated Show resolved Hide resolved
@enjoy-binbin @zuiderkwast
Update commands/eval.md
f5a5791 
Co-authored-by: Viktor Söderqvist <[email protected]>
@zuiderkwast zuiderkwast merged commit 7dbeb33 into redis:master Mar 14, 2024
1 check failed
@enjoy-binbin enjoy-binbin deleted the info_evicted_scripts branch March 15, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oranagra oranagra oranagra left review comments

@zuiderkwast zuiderkwast zuiderkwast approved these changes

Assignees
No one assigned
Labels
to-be-merged should probably be merged soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enjoy-binbin @zuiderkwast @oranagra