Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: install-vsix on windows using file patterns #1654

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: install-vsix on windows using file patterns #1654

merged 1 commit into from
Dec 2, 2024

Conversation

pospisilf
Copy link
Contributor

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continuous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

@pospisilf pospisilf linked an issue Nov 29, 2024 that may be closed by this pull request
[🚫 Bug] install-vsix fails on windows when file pattern like ./**.vsix is provided #1354
Closed
@pospisilf pospisilf force-pushed the issue-450 branch 7 times, most recently from 77245e1 to fc85ca7 Compare November 30, 2024 19:49
@pospisilf pospisilf marked this pull request as ready for review November 30, 2024 22:14
@pospisilf pospisilf requested a review from djelinek November 30, 2024 22:14
@pospisilf pospisilf added the ready-for-review Pull Request is Ready for Review label Nov 30, 2024
djelinek
djelinek reviewed Dec 1, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
packages/extester/src/extester.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pospisilf pospisilf requested a review from djelinek December 2, 2024 17:29
@djelinek djelinek changed the title fix: install-vsix on windows fix: install-vsix on windows using file patterns Dec 2, 2024
@djelinek djelinek added the bug Something isn't working label Dec 2, 2024
@djelinek djelinek merged commit 95bc417 into redhat-developer:main Dec 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djelinek djelinek djelinek approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ready-for-review Pull Request is Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🚫 Bug] install-vsix fails on windows when file pattern like ./**.vsix is provided
2 participants
@pospisilf @djelinek