Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for VS Code 1.89.x #1293

Merged
merged 3 commits into from
May 6, 2024
Merged

feat: Add support for VS Code 1.89.x #1293

merged 3 commits into from
May 6, 2024

Conversation

djelinek
Copy link
Collaborator

@djelinek djelinek commented May 6, 2024

bump 'max' placeholder from 1.88.1 to 1.89.0

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continuous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

djelinek added 3 commits May 6, 2024 15:41
@djelinek
feat: Add support for VS Code 1.89.x
e07cea2 
bump 'max' placeholder from 1.88.1 to 1.89.0

Signed-off-by: Dominik Jelinek <[email protected]>
@djelinek
test: Deprecate VariableSectionItem.getVariableValueTooltip method
80fd204 
Signed-off-by: Dominik Jelinek <[email protected]>
@djelinek
test: Fix settingsEditor tests
04e9bbe 
Signed-off-by: Dominik Jelinek <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@djelinek djelinek linked an issue May 6, 2024 that may be closed by this pull request
[🚀 Request] Support for VS Code 1.89.x #1294
Closed
@djelinek djelinek added the enhancement New feature or request label May 6, 2024
@djelinek djelinek marked this pull request as ready for review May 6, 2024 14:31
@djelinek djelinek merged commit e941ccf into redhat-developer:main May 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🚀 Request] Support for VS Code 1.89.x
1 participant
@djelinek