DFBUGS-1258: [release-4.18] controllers: allow failover to complete when peer site is down

[rewantsoni]

For the failover to be completed, we need to reconcile the rbdMirror CR.
ocs-client creation was blocking the reconciliation of rbdMirror, hence
move the creation of ocs-client to where it is required

Manual Cherry pick of #2957

[openshift-ci-robot]

@rewantsoni: This pull request references [Jira Issue DFBUGS-1258](https://issues.redhat.com//browse/DFBUGS-1258), which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jilju

In response to this:

For the failover to be completed, we need to reconcile the rbdMirror CR.
ocs-client creation was blocking the reconciliation of rbdMirror, hence
move the creation of ocs-client to where it is required

Manual Cherry pick of #2957

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jilju.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@rewantsoni: This pull request references [Jira Issue DFBUGS-1258](https://issues.redhat.com//browse/DFBUGS-1258), which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jilju

In response to this:

For the failover to be completed, we need to reconcile the rbdMirror CR.
ocs-client creation was blocking the reconciliation of rbdMirror, hence
move the creation of ocs-client to where it is required

Manual Cherry pick of #2957

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [iamniting]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@rewantsoni: [Jira Issue DFBUGS-1258](https://issues.redhat.com//browse/DFBUGS-1258): All pull requests linked via external trackers have merged:

• red-hat-storage/ocs-operator#2961

[Jira Issue DFBUGS-1258](https://issues.redhat.com//browse/DFBUGS-1258) has been moved to the MODIFIED state.

In response to this:

For the failover to be completed, we need to reconcile the rbdMirror CR.
ocs-client creation was blocking the reconciliation of rbdMirror, hence
move the creation of ocs-client to where it is required

Manual Cherry pick of #2957

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.