Adding mechanism to test prometheus alerts #2270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
aruniiird
force-pushed
the
add-prometheus-metric-test
branch
26 times, most recently
from
152c796 to
2f02329
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-merge-robot
added
the
needs-rebase
aruniiird
force-pushed
the
add-prometheus-metric-test
branch
from
0c64fab to
9b3a6c2
Compare
openshift-merge-robot
removed
the
needs-rebase
aruniiird
force-pushed
the
add-prometheus-metric-test
branch
from
9b3a6c2 to
b5de721
Compare
openshift-merge-robot
added
the
needs-rebase
aruniiird
force-pushed
the
add-prometheus-metric-test
branch
from
b5de721 to
5d014ed
Compare
openshift-merge-robot
removed
the
needs-rebase
aruniiird
force-pushed
the
add-prometheus-metric-test
branch
7 times, most recently
from
ef7956a to
0e30bc9
Compare
aruniiird
force-pushed
the
add-prometheus-metric-test
branch
2 times, most recently
from
2e5db09 to
274369a
Compare
openshift-merge-robot
added
the
needs-rebase
aruniiird
force-pushed
the
add-prometheus-metric-test
branch
from
274369a to
71c4f27
Compare
openshift-merge-robot
removed
the
needs-rebase
|
@aruniiird: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
aruniiird
force-pushed
the
add-prometheus-metric-test
branch
from
71c4f27 to
e4c12c2
Compare
aruniiird
force-pushed
the
add-prometheus-metric-test
branch
2 times, most recently
from
d406a47 to
04d515c
Compare
openshift-merge-robot
added
the
needs-rebase
Signed-off-by: Arun Kumar Mohan <[email protected]>
Now user can pass any '.template' file, with or without
'{{.PrometheusRuleFile}}' template line in it. Code
will automatically add the needed template string accordingly.
This enables the user to use any test file, without any modification
and use it as a template file.
Signed-off-by: Arun Kumar Mohan <[email protected]>
Signed-off-by: Arun Kumar Mohan <[email protected]>
aruniiird
force-pushed
the
add-prometheus-metric-test
branch
from
04d515c to
b0ef9e2
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aruniiird The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mechanism to test ocs-operator metrics / alerts