Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new annotations #70

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

new annotations #70

wants to merge 4 commits into from

Conversation

fchastanet
Copy link

Hello,

first thanks for your project
I added some features with unit tests included

new annotations
- added @warning with badge
- added @constraint
- added @require
- added @feature with badge
- added @deprecated with badge
- added @trap
- added @env

The badge feature forced me to add an urlencode function to construct valid links

One little change
- updated @example allowing to change default script language

I also updated README.md example, removing the table because actually I discovered the rendered file viewing at source code.
The scrollbar on the table on github website was hiding the comparison.

Do not hesitate to give me your feedbacks

- added warning with badge
- added constraint
- added require
- added feature with badge
- added deprecated with badge
- added trap
- added env
- updated @example allowing to change default script language
@hyperupcall
Copy link
Contributor

hyperupcall commented Sep 21, 2023

Glad to see @deprecated supported (that would close my issue #46). One thing I'd like to add is that if it were me, I wouldn't want a badge to show for deprecated functions - just regular text somewhere - would be nice. That way, it aligns with all the other features - being text-only and showing without an internet connection.

@fchastanet
Copy link
Author

Glad to see @deprecated supported (that would close my issue #46). One thing I'd like to add is that if it were me, I wouldn't want a badge to show for deprecated functions - just regular text somewhere - would be nice. That way, it aligns with all the other features - being text-only and showing without an internet connection.

Thanks for the suggestion, actually it could be easily to implement it using a different style, as I implemented it in github style, it makes sense to implement it as a github badge.

Maybe you could create your own style starting from this branch.

@hyperupcall
Copy link
Contributor

hyperupcall commented Oct 10, 2023

When testing this change, I had trouble keeping the badge for @deprecated when @description was also specified. For example, the following:

# @name Project Name
# @brief Brief
# @description overview

# @description My super function. Not thread safe.
# @deprecated use some other thing instead
b() {
    :
}

results in:

# Project Name

Brief

## Overview

overview

## Index

* [b](#b)

### b

My super function. Not thread safe.
@deprecated use some other thing instead

@fchastanet
Copy link
Author

fchastanet commented Oct 10, 2023

When testing this change, I had trouble keeping the badge for @deprecated when @description was also specified. For example, the following:

Thanks to have reported it with a reproductible test case, I fixed it, you can check my commit
1f386d0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants