Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Hide Back button on TV player #1073

Closed

Conversation

KingLucius
Copy link
Contributor

  • Hides back button on loading layout.
  • Hides back button on TV player.
  • Centers the title & resolution on TV.

@KingLucius
Copy link
Contributor Author

Do you think about removing the centering of the title to another PR for redesigning the player and only keeps the hiding of the back button?

@fire-light42
Copy link
Collaborator

I get that this pr is according to the android design guidelines and makes misinputs harder. However before I merge this, have you tried the netflix tv navigation? It goes something like this:

<-      ↻            ->
Back  Restart   Next Episode

@KingLucius
Copy link
Contributor Author

I get that this pr is according to the android design guidelines and makes misinputs harder. However before I merge this, have you tried the netflix tv navigation? It goes something like this:

<-      ↻            ->
Back  Restart   Next Episode

I used it but tbh never touched the back on UI, only used the back button of remote
Let's try another design
Hold merging for now

@fire-light42
Copy link
Collaborator

I get that this pr is according to the android design guidelines and makes misinputs harder. However before I merge this, have you tried the netflix tv navigation? It goes something like this:

<-      ↻            ->
Back  Restart   Next Episode

I used it but tbh never touched the back on UI, only used the back button of remote Let's try another design Hold merging for now

Update on this?

@KingLucius
Copy link
Contributor Author

I get that this pr is according to the android design guidelines and makes misinputs harder. However before I merge this, have you tried the netflix tv navigation? It goes something like this:

<-      ↻            ->
Back  Restart   Next Episode

I used it but tbh never touched the back on UI, only used the back button of remote Let's try another design Hold merging for now

Update on this?

I think we should close this as there is more proper designs more than centering the title

@KingLucius
Copy link
Contributor Author

or let it open I will update on it soon

@KingLucius KingLucius marked this pull request as draft June 8, 2024 19:45
@KingLucius
Copy link
Contributor Author

image

@KingLucius
Copy link
Contributor Author

Will continue in #1139 for better implementation

@KingLucius KingLucius closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants