fix(helm): improve opensearch deployment #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonadoni
added a commit
to mdonadoni/reana
that referenced
this pull request
Nov 11, 2024
mdonadoni
force-pushed
the
opensearch-local-deployment
branch
from
fa1a9e8
to
3845e2e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #843 +/- ##
==========================================
- Coverage 31.08% 31.06% -0.02%
==========================================
Files 26 26
Lines 2487 2488 +1
==========================================
Hits 773 773
- Misses 1714 1715 +1
|
mdonadoni
changed the title
mdonadoni
added a commit
to mdonadoni/reana
that referenced
this pull request
Nov 11, 2024
mdonadoni
added a commit
to mdonadoni/reana
that referenced
this pull request
Nov 11, 2024
Avoid re-defining the `REANA_OPENSEARCH_PASSWORD` environment variable multiple times in reana-workflow-controller.
mdonadoni
force-pushed
the
opensearch-local-deployment
branch
2 times, most recently
from
cb81acc
to
3402412
Compare
mdonadoni
added a commit
to mdonadoni/reana
that referenced
this pull request
Nov 12, 2024
…nahub#843) When deploying REANA locally, allow OpenSearch to access root-owned directory by setting `fsGroup` to zero. This is needed to access `hostPath` volumes when deploying reana with kind and Docker.
mdonadoni
added a commit
to mdonadoni/reana
that referenced
this pull request
Nov 12, 2024
mdonadoni
added a commit
to mdonadoni/reana
that referenced
this pull request
Nov 12, 2024
Avoid re-defining the `REANA_OPENSEARCH_PASSWORD` environment variable multiple times in reana-workflow-controller.
tiborsimko
reviewed
Nov 12, 2024
| @@ -215,7 +215,7 @@ opensearch: | |||
| cn: "reana.io" | |||
| ttl: 365 | |||
| cert: | |||
| cn: "reana-opensearch-master.default.svc.cluster.local" | |||
There was a problem hiding this comment.
Cosmetics: s/opensearch/OpenSearch/ in the commit log.
| @@ -162,6 +161,7 @@ This Helm automatically prefixes all names using the release name to avoid colli | |||
| | `secrets.gitlab.REANA_GITLAB_OAUTH_APP_ID` | GitLab OAuth application id | None | | |||
| | `secrets.gitlab.REANA_GITLAB_OAUTH_APP_SECRET` | **[Do not use in production, use secrets instead]** GitLab OAuth application secret | None | | |||
| | `secrets.login` | **[Do not use in production, use secrets instead]** Third-party Keycloak identity provider consumer key and secret ([configuration details](https://docs.reana.io/administration/configuration/configuring-access/#keycloak-single-sign-on-configuration)) | `{}` | | |||
| | `secrets.opensearch.password` | **[Do not use in production, use secrets instead]** OpenSearch password for Basic Authentication | None | | |||
There was a problem hiding this comment.
Cosmetics: redefining instead of "re-defining" in the commit log.
…nahub#843) When deploying REANA locally, allow OpenSearch to access root-owned directory by setting `fsGroup` to zero. This is needed to access `hostPath` volumes when deploying reana with kind and Docker.
Avoid redefining the `REANA_OPENSEARCH_PASSWORD` environment variable multiple times in reana-workflow-controller.
mdonadoni
force-pushed
the
opensearch-local-deployment
branch
from
3402412
to
aad7dff
Compare
tiborsimko
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fsGroupto zero for local opensearch deployment (fix(helm): improve opensearch deployment #843)