reana-dev: update git commands to use gh CLI #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe-steduto
force-pushed
the
gh-tool-reana-dev
branch
from
d3d1d13
to
fbb2270
Compare
mdonadoni
reviewed
Sep 18, 2023
|
PS: a rebase is needed! 😉 |
giuseppe-steduto
force-pushed
the
gh-tool-reana-dev
branch
from
fbb2270
to
d115e90
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #723 +/- ##
==========================================
+ Coverage 18.93% 18.94% +0.01%
==========================================
Files 26 26
Lines 2271 2285 +14
==========================================
+ Hits 430 433 +3
- Misses 1841 1852 +11
|
giuseppe-steduto
force-pushed
the
gh-tool-reana-dev
branch
2 times, most recently
from
b2b8144
to
9183d21
Compare
mdonadoni
approved these changes
Oct 19, 2023
giuseppe-steduto
force-pushed
the
gh-tool-reana-dev
branch
from
9183d21
to
4b02a06
Compare
mdonadoni
reviewed
Oct 20, 2023
reana/reana_dev/git.py
Outdated
| component, | ||
| ) | ||
| else: | ||
| display_message( |
There was a problem hiding this comment.
display_message cannot be used when --automatic is not provided, as the line prefix (i.e. date and component) printed by display_message interferes with eval when running eval "$(reana-dev git-fork -c ALL -b firefox)"
There was a problem hiding this comment.
Right - my bad! Reverted it to click.echo.
giuseppe-steduto
force-pushed
the
gh-tool-reana-dev
branch
from
4b02a06
to
ebf1ac0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #483.