feat(gitlab): add filtering and pagination (#403) #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonadoni
added a commit
to mdonadoni/reana-ui
that referenced
this pull request
Mar 20, 2024
BREAKING CHANGE: The response of `gitlab_projects` API endpoint has been modified to also include the pagination details. Closes reanahub/reana-server#518
mdonadoni
changed the title
tiborsimko
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Works nicely 👍
Some release-news-oriented comments:
- the headlines could announce new functionality in a feature-oriented verbiage, for example:
feat(gitlab): add pagination for GitLab project lists (#403)
feat(gitlab): add filtering for GitLab project lists (#403)
- The breaking change news text could be altered to say that the endpoint response is not being modified here in r-ui, but that the component is only adapting to the new version from r-server, something like:
BREAKING CHANGE: The frontend code adapts to the new REST API server `gitlab_projects` endpoint which now includes the pagination details.
OTOH, it may be nice to use the same breaking change text in both r-server and r-ui, for easier referencing? In which case we could use some neutral language such as:
BREAKING CHANGE: The REST API endpoint `gitlab_projects` now includes pagination details.
in both r-server and r-ui.
BREAKING CHANGE: The REST API endpoint `gitlab_projects` now includes pagination details. Closes reanahub/reana-server#518
mdonadoni
force-pushed
the
filter-paginate-gitlab
branch
from
06e15f8
to
d403634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(gitlab): add filtering for GitLab project lists (feat(gitlab): add filtering and pagination (#403) #403)
feat(gitlab): add pagination for GitLab project lists (feat(gitlab): add filtering and pagination (#403) #403)
BREAKING CHANGE: The REST API endpoint
gitlab_projectsnow includespagination details.
Closes reanahub/reana-server#518