ui: add item to actions popup to allow stopping workflow #332
Conversation
| menuItems.push({ | ||
| key: "stop", | ||
| content: "Stop workflow", | ||
| icon: "stop", |
There was a problem hiding this comment.
I have used the stop icon in the actions popup, but we are already using the pause icon when showing stopped workflows in the UI:
Is this ok, or should pause be used here instead of stop (or viceversa)?
There was a problem hiding this comment.
I like the stop icon in the actions popup, because pause usually refers to something that can be resumed later, and that's not the case here.
For this reason I would also prefer changing the pause icon in the workflow list to something else. Using stop circle outline would work, with the small downside that in general the stop icon is used only as an action icon, rather than as a status icon. However, IMHO it's better than conveying the information that a stopped workflow can be resumed.
There was a problem hiding this comment.
Updated to use the stop icon also in the workflow list
|
Comment regarding this PR: the changes in this PR are similar to what is done to implement the Delete workflow action, so there is a bit of duplicated code. I think we can keep this for the time being, and improve this later when we will add more actions to the UI. What do you think? |
There was a problem hiding this comment.
Works well! I just left a minor comment about the stop / pause icon.
This PR does indeed introduce some code duplication, but I agree on it being okay for now. Removing this duplication would involve quite a bit of refactoring, and we will probably have a better idea on what to group under common components / functions when we add another entry to the actions popup, since the "delete" and "stop" actions are very similar.
Another note, not directly related to this PR, but rather to the way in which stopped workflows are displayed. The timer that usually says for how long a workflow has been running doesn't stop when the workflow is stopped. This results in the "stopped after X minutes Y seconds" phrase with X and Y constantly increasing as time passes. Also, opening the "job logs" tab of a stopped workflow, the different jobs are still in running status, with the timer that is still ongoing and constantly increasing.
This behavior persists even after the stopped workflow is deleted.
Could you please open an issue? Thanks! |
Closes reanahub/reana#724