feat(config): set maximum limit for number of workers #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Nov 5, 2024
Alputer
force-pushed
the
dask-max-worker-config
branch
from
284cf8b
to
cdba3b1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #712 +/- ##
==========================================
- Coverage 60.08% 60.06% -0.02%
==========================================
Files 32 32
Lines 3550 3556 +6
==========================================
+ Hits 2133 2136 +3
- Misses 1417 1420 +3
|
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Nov 11, 2024
Alputer
force-pushed
the
dask-max-worker-config
branch
from
cdba3b1
to
9830523
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Nov 11, 2024
Alputer
force-pushed
the
dask-max-worker-config
branch
from
9830523
to
4347c90
Compare
Alputer
changed the title
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Nov 11, 2024
Alputer
force-pushed
the
dask-max-worker-config
branch
from
4347c90
to
857624a
Compare
tiborsimko
reviewed
Nov 11, 2024
reana_server/validation.py
Outdated
|
|
||
| if number_of_workers > REANA_DASK_CLUSTER_MAX_NUMBER_OF_WORKERS: | ||
| raise REANAValidationError( | ||
| f'The "number_of_workers" provided in the dask resources exceeds the limit ({REANA_DASK_CLUSTER_MAX_NUMBER_OF_WORKERS}).' |
There was a problem hiding this comment.
Cosmetics: "The number of requested Dask workers (123) exceeds the maximum limit (20)."
Alputer
force-pushed
the
dask-max-worker-config
branch
from
857624a
to
d36b59b
Compare
tiborsimko
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.