feat(helm): add initial Dask support #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Sep 13, 2024
Alputer
force-pushed
the
dask-integration
branch
from
c5a2e9e
to
bdab669
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #701 +/- ##
==========================================
+ Coverage 60.01% 60.06% +0.05%
==========================================
Files 32 32
Lines 3509 3546 +37
==========================================
+ Hits 2106 2130 +24
- Misses 1403 1416 +13
|
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Sep 13, 2024
Alputer
force-pushed
the
dask-integration
branch
from
bdab669
to
49c12e9
Compare
Alputer
changed the title
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Sep 15, 2024
Alputer
force-pushed
the
dask-integration
branch
from
49c12e9
to
7c0f3e4
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Sep 15, 2024
Alputer
force-pushed
the
dask-integration
branch
from
7c0f3e4
to
266fe9b
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Sep 16, 2024
Alputer
force-pushed
the
dask-integration
branch
from
266fe9b
to
fc9c420
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Sep 16, 2024
Alputer
force-pushed
the
dask-integration
branch
from
fc9c420
to
95f7574
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Sep 16, 2024
Alputer
force-pushed
the
dask-integration
branch
from
95f7574
to
64f7feb
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Sep 17, 2024
Alputer
force-pushed
the
dask-integration
branch
from
64f7feb
to
73ab0ea
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Sep 19, 2024
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Sep 20, 2024
This was referenced Sep 20, 2024
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Sep 25, 2024
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Sep 25, 2024
Alputer
force-pushed
the
dask-integration
branch
from
989c87e
to
4b05f17
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Sep 25, 2024
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Oct 24, 2024
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Oct 24, 2024
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Oct 24, 2024
Alputer
force-pushed
the
dask-integration
branch
from
a7ea4f9
to
434e95a
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Oct 24, 2024
Alputer
force-pushed
the
dask-integration
branch
3 times, most recently
from
376363e
to
3b7f99b
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Oct 24, 2024
Alputer
force-pushed
the
dask-integration
branch
from
3b7f99b
to
4543023
Compare
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Oct 30, 2024
Alputer
force-pushed
the
dask-integration
branch
from
4543023
to
482b597
Compare
tiborsimko
reviewed
Oct 30, 2024
| REANA_DASK_CLUSTER_MAX_MEMORY_LIMIT | ||
| ): | ||
| raise REANAValidationError( | ||
| f'The "memory" requested in the dask resources exceeds the limit ({REANA_DASK_CLUSTER_MAX_MEMORY_LIMIT}).\nDecrease the number of workers requested or amount of memory consumed by a single worker.' |
There was a problem hiding this comment.
The limit testing seems to work nicely, I have tested a few scenarios.
reana_server/rest/info.py
Outdated
| value=REANA_DASK_CLUSTER_MAX_MEMORY_LIMIT, | ||
| ) | ||
| cluster_information["dask_cluster_default_single_worker_memory"] = dict( | ||
| title="Memory for one Dask worker by default", |
There was a problem hiding this comment.
For the documentation strings (titles), please see the comments to the reana and reana-commons repositories.
Alputer
added a commit
to Alputer/reana-server
that referenced
this pull request
Oct 30, 2024
Alputer
force-pushed
the
dask-integration
branch
from
482b597
to
6b1d839
Compare
Alputer
force-pushed
the
dask-integration
branch
from
6b1d839
to
15d0b97
Compare
Alputer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the ongoing work of dask integration into REANA.