Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reana-admin): skip retention rules with deleted workspace (#697) #697

Merged

Conversation

mdonadoni
Copy link
Member

Closes #693

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.84%. Comparing base (3596ee0) to head (d1cd1a5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
reana_server/reana_admin/cli.py 40.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #697      +/-   ##
==========================================
- Coverage   60.87%   60.84%   -0.04%     
==========================================
  Files          33       33              
  Lines        3458     3463       +5     
==========================================
+ Hits         2105     2107       +2     
- Misses       1353     1356       +3     
Files with missing lines Coverage Δ
reana_server/reana_admin/cli.py 51.79% <40.00%> (-0.12%) ⬇️

mdonadoni added a commit to mdonadoni/reana-server that referenced this pull request Aug 9, 2024
@mdonadoni mdonadoni force-pushed the retention-rules-deleted-workflow branch from 024b5da to 1d776f3 Compare August 9, 2024 10:30
mdonadoni added a commit to mdonadoni/reana-server that referenced this pull request Aug 26, 2024
@mdonadoni mdonadoni force-pushed the retention-rules-deleted-workflow branch from 1d776f3 to 30b2cfc Compare August 26, 2024 13:43
Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely 👍

Commit news suggestion:

fix(reana-admin): skip retention rules for deleted workspaces (#697) 

@mdonadoni mdonadoni force-pushed the retention-rules-deleted-workflow branch from 30b2cfc to d1cd1a5 Compare August 29, 2024 09:56
@tiborsimko tiborsimko merged commit d1cd1a5 into reanahub:master Aug 29, 2024
12 checks passed
@mdonadoni mdonadoni deleted the retention-rules-deleted-workflow branch August 29, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

retention_rules: error when applying rule to deleted workflow
2 participants