fix(start): validate endpoint parameters (#689) #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Jun 25, 2024
mdonadoni
force-pushed
the
parameters-start-workflow
branch
from
8c11e2d
to
a7cb1d7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## maint-0.9 #689 +/- ##
=============================================
+ Coverage 59.46% 60.18% +0.72%
=============================================
Files 32 32
Lines 3298 3320 +22
=============================================
+ Hits 1961 1998 +37
+ Misses 1337 1322 -15
|
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Jun 26, 2024
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Jun 26, 2024
mdonadoni
force-pushed
the
parameters-start-workflow
branch
from
a7cb1d7
to
4df0591
Compare
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Jul 2, 2024
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Jul 2, 2024
mdonadoni
force-pushed
the
parameters-start-workflow
branch
from
4df0591
to
2199256
Compare
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Jul 2, 2024
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Jul 2, 2024
mdonadoni
force-pushed
the
parameters-start-workflow
branch
from
6d094a7
to
90fb451
Compare
tiborsimko
reviewed
Jul 3, 2024
docs/openapi.json
Outdated
| @@ -3198,15 +3198,19 @@ | |||
| "schema": { | |||
| "properties": { | |||
| "input_parameters": { | |||
| "description": "Optional. Additional input parameters that override the ones in the workflow specification.", | |||
There was a problem hiding this comment.
Optional. Additional input parameters that override the ones from the workflow specification.
docs/openapi.json
Outdated
| "type": "object" | ||
| }, | ||
| "operational_options": { | ||
| "description": "Optional. Operational options for workflow execution.", |
There was a problem hiding this comment.
Optional. Additional operational options for workflow execution.
| type: object | ||
| input_parameters: | ||
| description: >- |
There was a problem hiding this comment.
See description verbiage comments above.
| @@ -56,15 +56,25 @@ check_commitlint () { | |||
| npx commitlint --from="$from" --to="$to" | |||
| found=0 | |||
| while IFS= read -r line; do | |||
| if echo "$line" | grep -qP "\(\#$pr\)$"; then | |||
| commit_hash=$(echo "$line" | cut -d ' ' -f 1) | |||
There was a problem hiding this comment.
Instead of the commit message saying in a negatively-worded tense:
ci(commitlint): do not check merge commit's ancestors
What about putting a positively-worded message:
ci(commitlint): improve checking of merge commits
As we did in several other PRs such as merge-0.9-to-master ones?
mdonadoni
force-pushed
the
parameters-start-workflow
branch
from
90fb451
to
69f45fc
Compare
tiborsimko
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes reanahub/reana-client#718