-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin: detect out-of-sync workspaces #627
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #627 +/- ##
==========================================
+ Coverage 59.20% 59.48% +0.27%
==========================================
Files 32 32
Lines 3236 3283 +47
==========================================
+ Hits 1916 1953 +37
- Misses 1320 1330 +10
|
mdonadoni
force-pushed
the
check-workflows-disk
branch
3 times, most recently
from
September 15, 2023 13:47
094b1a5
to
8d0e932
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works well! Just left a comment about checks for deleted workflows.
mdonadoni
force-pushed
the
check-workflows-disk
branch
from
September 18, 2023 12:26
8d0e932
to
4e5412a
Compare
giuseppe-steduto
approved these changes
Sep 20, 2023
Improve the `check-workflows` command to also report workspaces that are present on disk, but that are not owned by any workflows present in the database. Moreover, the `check-workflows` command now also reports workflows whose workspaces are not present on disk. Closes reanahub#623
Change `check-workflows` to not show in-sync workflows/sessions/workspaces by default. If needed, those can be shown with the new `--show-all` option. Closes reanahub#626
mdonadoni
force-pushed
the
check-workflows-disk
branch
from
September 20, 2023 12:04
4e5412a
to
a339846
Compare
Updated CHANGES.rst and merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the
check-workflows
command to also report workspaces that arepresent on disk, but that are not owned by any workflows present in the
database. Moreover, the
check-workflows
command now also reportsworkflows whose workspaces are not present on disk.
Closes #623
Change
check-workflows
to not show in-syncworkflows/sessions/workspaces by default. If needed, those can be shown
with the new
--show-all
option.Closes #626