Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin: detect out-of-sync workspaces #627

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

mdonadoni
Copy link
Member

@mdonadoni mdonadoni commented Sep 14, 2023

Improve the check-workflows command to also report workspaces that are
present on disk, but that are not owned by any workflows present in the
database. Moreover, the check-workflows command now also reports
workflows whose workspaces are not present on disk.

Closes #623

Change check-workflows to not show in-sync
workflows/sessions/workspaces by default. If needed, those can be shown
with the new --show-all option.

Closes #626

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #627 (a339846) into master (9542f72) will increase coverage by 0.27%.
The diff coverage is 67.16%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #627      +/-   ##
==========================================
+ Coverage   59.20%   59.48%   +0.27%     
==========================================
  Files          32       32              
  Lines        3236     3283      +47     
==========================================
+ Hits         1916     1953      +37     
- Misses       1320     1330      +10     
Files Changed Coverage Δ
reana_server/reana_admin/cli.py 51.73% <11.11%> (-0.88%) ⬇️
reana_server/reana_admin/check_workflows.py 82.75% <87.75%> (+4.34%) ⬆️

@mdonadoni mdonadoni force-pushed the check-workflows-disk branch 3 times, most recently from 094b1a5 to 8d0e932 Compare September 15, 2023 13:47
Copy link
Member

@giuseppe-steduto giuseppe-steduto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well! Just left a comment about checks for deleted workflows.

reana_server/reana_admin/check_workflows.py Show resolved Hide resolved
reana_server/reana_admin/check_workflows.py Show resolved Hide resolved
tests/test_cli.py Outdated Show resolved Hide resolved
Improve the `check-workflows` command to also report workspaces that are
present on disk, but that are not owned by any workflows present in the
database. Moreover, the `check-workflows` command now also reports
workflows whose workspaces are not present on disk.

Closes reanahub#623
Change `check-workflows` to not show in-sync
workflows/sessions/workspaces by default. If needed, those can be shown
with the new `--show-all` option.

Closes reanahub#626
@mdonadoni mdonadoni merged commit a339846 into reanahub:master Sep 20, 2023
11 checks passed
@mdonadoni
Copy link
Member Author

Updated CHANGES.rst and merged!

@mdonadoni mdonadoni deleted the check-workflows-disk branch September 20, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants