Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest: add run_stopped_at to status endpoint #606

Merged

Conversation

giuseppe-steduto
Copy link
Member

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Merging #606 (ae95887) into master (fa056f4) will not change coverage.
The diff coverage is n/a.

❗ Current head ae95887 differs from pull request most recent head b848c11. Consider uploading reports for the commit b848c11 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #606   +/-   ##
=======================================
  Coverage   59.30%   59.30%           
=======================================
  Files          32       32           
  Lines        3229     3229           
=======================================
  Hits         1915     1915           
  Misses       1314     1314           
Files Changed Coverage Δ
reana_server/rest/workflows.py 53.63% <ø> (ø)

... and 1 file with indirect coverage changes

CHANGES.rst Outdated
@@ -4,6 +4,7 @@ Changes
Version 0.9.1 (UNRELEASED)
--------------------------

- Changes OpenAPI specification to include the ``run_stopped_at`` property in the ``progress`` value returned by the ``status`` endpoint.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Changes OpenAPI specification to include the ``run_stopped_at`` property in the ``progress`` value returned by the ``status`` endpoint.
- Adds the timestamp of when the workflow was stopped (``run_stopped_at``) to the workflow list and the workflow status endpoints.

Copy link
Member

@mdonadoni mdonadoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

PS: this PR needs to be rebased

@mdonadoni mdonadoni merged commit b848c11 into reanahub:master Aug 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time after which the workflow is stopped incorrectly updated
3 participants