Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin: standardize --admin-access-token usage #595

Merged
merged 3 commits into from
Jun 30, 2023

Conversation

audrium
Copy link
Member

@audrium audrium commented Jun 2, 2023

closes #489

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #595 (fd0af51) into master (cf1ecd5) will increase coverage by 0.14%.
The diff coverage is 83.78%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
+ Coverage   59.12%   59.27%   +0.14%     
==========================================
  Files          32       32              
  Lines        3227     3224       -3     
==========================================
+ Hits         1908     1911       +3     
+ Misses       1319     1313       -6     
Impacted Files Coverage Δ
reana_server/decorators.py 82.22% <ø> (-2.69%) ⬇️
reana_server/reana_admin/options.py 82.35% <80.00%> (-2.65%) ⬇️
reana_server/reana_admin/cli.py 52.60% <82.35%> (+0.61%) ⬆️
reana_server/utils.py 57.14% <100.00%> (+1.03%) ⬆️

Copy link
Member

@mdonadoni mdonadoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

Could you please also update the Helm Chart to provide the access token to the cronjobs, and the docs to update the command usage examples?

This PR also needs to be rebased.

reana_server/utils.py Outdated Show resolved Hide resolved
reana_server/decorators.py Outdated Show resolved Hide resolved
reana_server/decorators.py Show resolved Hide resolved
@mdonadoni mdonadoni force-pushed the reana-admin-access-token-usage branch from c943a01 to 6501019 Compare June 29, 2023 12:33
Remove admin access token validation from some users-related utilities,
as these checks are already performed by the admin CLI.
@mdonadoni mdonadoni force-pushed the reana-admin-access-token-usage branch from 6501019 to fd0af51 Compare June 29, 2023 12:40
Copy link
Member

@giuseppe-steduto giuseppe-steduto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected!

@mdonadoni mdonadoni merged commit fd0af51 into reanahub:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

admin: standardize --admin-access-token usage
4 participants